From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Sun, 25 Sep 2016 11:18:47 +0000 Subject: Re: [PATCH 5/5] ISDN-CAPI: Delete unnecessary braces Message-Id: <52dd5000-2bda-a1b6-aa97-1868e1193d35@cogentembedded.com> List-Id: References: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> In-Reply-To: <06e7637c-f682-bfa2-82b6-47d071bd58c4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , netdev@vger.kernel.org, Karsten Keil Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Hello. On 9/25/2016 2:15 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 25 Sep 2016 12:50:21 +0200 > > Do not use curly brackets at eight source code places > where a single statement should be sufficient. > > Signed-off-by: Markus Elfring > --- > drivers/isdn/capi/capidrv.c | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c > index 83f756d..7f58644 100644 > --- a/drivers/isdn/capi/capidrv.c > +++ b/drivers/isdn/capi/capidrv.c [...] > @@ -976,13 +974,12 @@ static void handle_controller(_cmsg *cmsg) > if (debugmode) > printk(KERN_DEBUG "capidrv-%d: listenconf Info=0x%4x (%s) cipmask=0x%x\n", > card->contrnr, cmsg->Info, capi_info2str(cmsg->Info), card->cipmask); > - if (cmsg->Info) { > + if (cmsg->Info) > listen_change_state(card, EV_LISTEN_CONF_ERROR); > - } else if (card->cipmask = 0) { > + else if (card->cipmask = 0) > listen_change_state(card, EV_LISTEN_CONF_EMPTY); > - } else { > + else Indented too much. [...] MBR, Sergei