From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Wed, 02 Apr 2014 14:08:59 +0000 Subject: Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync Message-Id: <533C19FB.8090302@roeck-us.net> List-Id: References: <1396360159-16244-1-git-send-email-Julia.Lawall@lip6.fr> <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1396360159-16244-4-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall , Wim Van Sebroeck Cc: kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org On 04/01/2014 06:49 AM, Julia Lawall wrote: > From: Julia Lawall > > Use del_timer_sync to ensure that the timer is stopped on all CPUs before > the driver exits. > > This change was suggested by Thomas Gleixner. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @r@ > identifier i,t,ex; > @@ > struct t i = { .remove = ex, }; > > @@ > identifier r.ex; > @@ > ex(...) { > <... > - del_timer > + del_timer_sync > (...) > ...> > } > // > > Signed-off-by: Julia Lawall > Reviewed-by: Guenter Roeck