public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: vme: Fix a small coding style issue in vme_user.c
Date: Thu, 03 Apr 2014 15:14:29 +0000	[thread overview]
Message-ID: <533D7AD5.8070509@bfs.de> (raw)
In-Reply-To: <1396477450-5354-1-git-send-email-prtvar.b@gmail.com>



Am 03.04.2014 00:24, schrieb Bojan Prtvar:
> The checkpatch.pl complains about missing blank line after declaration.
> This patch silence the warning.
> 
> Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
> ---
>  This patch is for Eudyptula Challenge task 10
> 
>  drivers/staging/vme/devices/vme_user.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index 7927927..481192a 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -791,6 +791,7 @@ static int vme_user_probe(struct vme_dev *vdev)
>  	/* Add sysfs Entries */
>  	for (i = 0; i < VME_DEVS; i++) {
>  		int num;
> +
>  		switch (type[i]) {
>  		case MASTER_MINOR:
>  			sprintf(name, "bus/vme/m%%d");

beside style:
that sprint looks like as it could be replaced with a
 name="bus/vme/m%%d"

any takers ?

re,
 wh


  reply	other threads:[~2014-04-03 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 22:24 [PATCH] staging: vme: Fix a small coding style issue in vme_user.c Bojan Prtvar
2014-04-03 15:14 ` walter harms [this message]
2014-04-03 15:40 ` bojan prtvar
2014-04-03 15:52 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533D7AD5.8070509@bfs.de \
    --to=wharms@bfs.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox