From mboxrd@z Thu Jan  1 00:00:00 1970
From: walter harms <wharms@bfs.de>
Date: Wed, 11 Jun 2014 07:36:49 +0000
Subject: Re: [patch] iio: adc: at91: signedness bug in at91_adc_get_trigger_value_by_name()
Message-Id: <53980711.5030604@bfs.de>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20140611065356.GB16443@mwanda>
In-Reply-To: <20140611065356.GB16443@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Grant Likely <grant.likely@linaro.org>, Rob Herring <robh+dt@kernel.org>, Josh Wu <josh.wu@atmel.com>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Nicolas Ferre <nicolas.ferre@atmel.com>, Maxime Ripard <maxime.ripard@free-electrons.com>, Lars-Peter Clausen <lars@metafoo.de>, Thomas Meyer <thomas@m3y3r.de>, Wei Yongjun <yongjun_wei@trendmicro.com.cn>, Sachin Kamat <sachin.kamat@linaro.org>, linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org



Am 11.06.2014 08:53, schrieb Dan Carpenter:
> The function returns a u8 so the -ENOMEM is truncated to a positive
> value.  The caller tests for zero returns and treats them as an error
> so I have changed the -ENOMEM to 0.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index 3b5bacd..5ebe33d 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -525,7 +525,7 @@ static u8 at91_adc_get_trigger_value_by_name(struct iio_dev *idev,
>  				idev->id,
>  				triggers[i].name);
>  		if (!name)
> -			return -ENOMEM;
> +			return 0;
>  
>  		if (strcmp(trigger_name, name) = 0) {
>  			value = triggers[i].value;


hi Dan,
LXR says there is only 1 caller (and he is checking for ENOMON)
perhaps it is better to change  the return value to int.

re,
 wh