Re: ALSA: nm256: Fine-tuning for three function implementations

Takashi Iwai
2017-11-28T19:43:45Z

On Tue, 28 Nov 2017 20:08:13 +0100,
SF Markus Elfring wrote:
>
> >> Examples:
> >> * ALSA: cs5530: Use common error handling code in snd_cs5530_probe()
> >> https://lkml.org/lkml/2017/11/18/266
> >> https://patchwork.kernel.org/patch/10064945/
> >> https://lkml.kernel.org/r/<a2cb6494-a01c-668a-cd9b-1a8428a0d4c9@users.sourceforge.net>
> >
> > This is no trivial patch.
>
> Why do you find this one more challenging now than a similar one?
>
> ALSA: maestro3: Use common error handling code in two functions
> https://lkml.org/lkml/2017/9/6/39
> https://patchwork.kernel.org/patch/9939985/
> https://lkml.kernel.org/r/<83b1ba49-253d-72ed-b3b0-ec7d5e72a12c@users.sourceforge.net>

Because it turned out that your patch can be wrong and broken.

Takashi