From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Date: Tue, 08 Jul 2014 11:40:44 +0000 Subject: Re: [PATCH 2/3] gpu: drm: Remove unnecessary parameter from drm_ht_remove_item() Message-Id: <53BBD8BC.7040602@vmware.com> List-Id: References: <1403646734-2838-1-git-send-email-massa.nomura@gmail.com> <1403646734-2838-3-git-send-email-massa.nomura@gmail.com> <20140708112442.GA17271@phenom.ffwll.local> In-Reply-To: <20140708112442.GA17271@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Masaru Nomura , airlied@linux.ie, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org On 07/08/2014 01:24 PM, Daniel Vetter wrote: > On Tue, Jun 24, 2014 at 10:52:13PM +0100, Masaru Nomura wrote: >> removed drm_open_hash from drm_ht_remove_item() as the parameter is >> not used within the function. >> >> Signed-off-by: Masaru Nomura >> --- >> Please review this patch carefully. The reason the parameter is passed >> might be some historical one or clarity of which drm_open_hash >> we remove an item from. > Reasons for this are probably lost. On the patch: > > Reviewed-by: Daniel Vetter Acked-by: Thomas Hellstrom > > Aside: Imo we could/should just move all the users to directly employ the > linux hashtab instead of partially reinventing the wheel here in drm. > -Daniel > Actually, in this case, the wheel was invented in drm before it was made generic :). It's possible to utilize part of "hashtable.h" but I don't think the code size gain will be major... /Thomas