From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 08 Mar 2017 13:15:34 +0000 Subject: [PATCH 16/26] IB/ocrdma: Adjust a null pointer check in ocrdma_alloc_resources() Message-Id: <54750756-91cd-b508-109a-83b7b2375193@users.sourceforge.net> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-rdma@vger.kernel.org, Devesh Sharma , Doug Ledford , Hal Rosenstock , Sean Hefty , Selvin Xavier Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Tue, 7 Mar 2017 22:34:33 +0100 The script "checkpatch.pl" pointed information out like the following. Comparison to NULL could be written "!dev->stag_arr". Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index 93113feeb2d5..fbf672c79d5f 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -238,7 +238,7 @@ static int ocrdma_alloc_resources(struct ocrdma_dev *dev) dev->stag_arr = kcalloc(OCRDMA_MAX_STAG, sizeof(*dev->stag_arr), GFP_KERNEL); - if (dev->stag_arr = NULL) + if (!dev->stag_arr) goto alloc_err; ocrdma_alloc_pd_pool(dev); -- 2.12.0