From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 05 Dec 2014 07:18:55 +0000 Subject: Re: [PATCH v2 1/6] net-PPP: Replacement of a printk() call by pr_warn() in mppe_rekey() Message-Id: <54815C5F.8090702@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <547B4886.4080406@users.sourceforge.net> <547B496E.604@users.sourceforge.net> <547C5CBC.6060607@cogentembedded.com> <547C82A6.2030808@users.sourceforge.net> <547CA157.1080401@cogentembedded.com> <5480DA32.8000201@users.sourceforge.net> <5480DBDE.7040604@users.sourceforge.net> <1417731809.2721.17.camel@perches.com> <5480DFB5.4090708@users.sourceforge.net> <1417733101.2721.20.camel@perches.com> In-Reply-To: <1417733101.2721.20.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: Sergei Shtylyov , Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Eric Dumazet , LKML , kernel-janitors@vger.kernel.org, Julia Lawall >>> It's generally nicer to replace embedded function names >>> with "%s: ", __func__ >>> >>> pr_warn("%s: cipher_encrypt failed\n", __func__); >> >> Do you want that I send a third patch series for the fine-tuning of these parameters? > > If you want. Would "a committer" fix such a small source code adjustment also without a resend of a patch series? > I just wanted you to be aware of it for future patches. Thanks for your tip. Does it make sense to express such implementation details in the Linux coding style documentation more explicitly (besides the fact that this update suggestion was also triggered by a warning from the script "checkpatch.pl"). Regards, Markus