kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 5/6] usb: gadget: uvc: make a bunch of stuff static
Date: Thu, 15 Jan 2015 11:06:22 +0000	[thread overview]
Message-ID: <54B79F2E.2070608@samsung.com> (raw)
In-Reply-To: <20150114210352.GE23203@mwanda>

W dniu 14.01.2015 o 23:45, Felipe Balbi pisze:
> On Thu, Jan 15, 2015 at 12:03:52AM +0300, Dan Carpenter wrote:
>> Sparse rightly complains that these things should be static since they
>> are only used in the one .c file.
>>


There has already been a patch for this:

http://www.spinics.net/lists/linux-usb/msg119646.html


>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> fails to apply on top of my testing/next
>
> checking file drivers/usb/gadget/function/uvc_configfs.c
> Hunk #1 FAILED at 43.
> Hunk #2 FAILED at 135.
> Hunk #3 FAILED at 161.
> Hunk #4 FAILED at 718.
> Hunk #5 FAILED at 795.
> Hunk #6 FAILED at 947.
> Hunk #7 FAILED at 973.
> Hunk #8 FAILED at 1017.
> Hunk #9 FAILED at 1260.
> Hunk #10 FAILED at 1311.
> Hunk #11 FAILED at 1334.
> Hunk #12 FAILED at 1544.
> Hunk #13 FAILED at 1582.
> Hunk #14 FAILED at 1606.
> Hunk #15 FAILED at 1757.
> Hunk #16 FAILED at 1789.
> 16 out of 16 hunks FAILED
>
> please rebase on that branch.
>


      parent reply	other threads:[~2015-01-15 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 21:03 [patch 5/6] usb: gadget: uvc: make a bunch of stuff static Dan Carpenter
2015-01-14 22:45 ` Felipe Balbi
2015-01-15 11:06 ` Andrzej Pietrasiewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B79F2E.2070608@samsung.com \
    --to=andrzej.p@samsung.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).