From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Date: Fri, 16 Jan 2015 12:44:44 +0000
Subject: Re: [patch 2/6] usb: gadget: uvc: cleanup __uvcg_fill_strm()
Message-Id: <54B907BC.9090207@samsung.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150114210107.GB23203@mwanda>
In-Reply-To: <20150114210107.GB23203@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

W dniu 16.01.2015 o 13:12, Dan Carpenter pisze:
> Oh, yeah.  You're right.  I should have been more careful and I should
> have seen that.  Sorry.  But the problem is the original code is still a
> bit buggy.
>
> We call:
>
> 	data = kzalloc();
>
> Inside __uvcg_fill_strm() we do "data += something;"
>
> 	kfree(data);
>
> We should save the orignal data pointer so that we can free it
> correctly at the end in uvcg_streaming_class_allow_link().
>
Yeah, right. Thank you for spotting this. The kfree() is called
only if __uvcg_fill_strm() fails, though. But of course this needs
to be fixed.

AP