From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 18 Jan 2015 14:37:42 +0000 Subject: [PATCH 1/3] block-cciss: Deletion of an unnecessary check before the function call "put_disk" Message-Id: <54BBC536.5010006@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <54BBC3AB.6040207@users.sourceforge.net> In-Reply-To: <54BBC3AB.6040207@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Don Brace , iss_storagedev@hp.com, storagedev@pmcs.com, linux-scsi@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 18 Jan 2015 11:14:16 +0100 The put_disk() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/block/cciss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index ff20f19..4be0de0 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c @@ -4424,8 +4424,7 @@ static void free_hba(ctlr_info_t *h) hba[h->ctlr] = NULL; for (i = 0; i < h->highest_lun + 1; i++) - if (h->gendisk[i] != NULL) - put_disk(h->gendisk[i]); + put_disk(h->gendisk[i]); kfree(h); } -- 2.2.2