From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Bas Peters <baspeters93@gmail.com>,
Christine Caulfield <ccaulfie@redhat.com>,
David Teigland <teigland@redhat.com>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH] fs: dlm: lockspace.c: removal of unnecessary check before calling kfree()
Date: Wed, 11 Feb 2015 12:10:34 +0000 [thread overview]
Message-ID: <54DB46BA.7020803@users.sourceforge.net> (raw)
In-Reply-To: <1423646814-22720-1-git-send-email-baspeters93@gmail.com>
> kfree() checks its argument. It is therefore unnecessary to do this twice.
>
> This issue was detected using Coccinelle.
Would you like to integrate my update suggestion 'fs-DLM: Deletion of
unnecessary checks before the function call "kfree"'?
https://lkml.org/lkml/2014/11/29/88
http://article.gmane.org/gmane.linux.kernel/1840524
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg778279.html
Regards,
Markus
next prev parent reply other threads:[~2015-02-11 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 9:26 [PATCH] fs: dlm: lockspace.c: removal of unnecessary check before calling kfree() Bas Peters
2015-02-11 12:10 ` SF Markus Elfring [this message]
2015-02-11 12:12 ` Bas Peters
2015-02-11 12:20 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB46BA.7020803@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=baspeters93@gmail.com \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).