* re: kdbus: add connection, queue handling and message validation code
@ 2015-03-17 18:29 Dan Carpenter
2015-03-17 18:49 ` Daniel Mack
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-03-17 18:29 UTC (permalink / raw)
To: kernel-janitors
Hello Daniel Mack,
The patch 5fc8dd5c84fc: "kdbus: add connection, queue handling and
message validation code" from Sep 11, 2014, leads to the following
static checker warning:
ipc/kdbus/connection.c:2000 kdbus_cmd_send()
warn: 'cancel_fd' isn't an ERR_PTR
ipc/kdbus/connection.c
1998 if (argv[1].item) {
1999 cancel_fd = fget(argv[1].item->fds[0]);
^^^^
fget() returns NULL on error.
2000 if (IS_ERR(cancel_fd)) {
2001 ret = PTR_ERR(cancel_fd);
2002 cancel_fd = NULL;
2003 goto exit;
2004 }
2005
2006 if (!cancel_fd->f_op->poll) {
2007 ret = -EINVAL;
2008 goto exit;
2009 }
2010 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: kdbus: add connection, queue handling and message validation code
2015-03-17 18:29 kdbus: add connection, queue handling and message validation code Dan Carpenter
@ 2015-03-17 18:49 ` Daniel Mack
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Mack @ 2015-03-17 18:49 UTC (permalink / raw)
To: kernel-janitors
Hi Dan,
On 03/17/2015 07:29 PM, Dan Carpenter wrote:
> Hello Daniel Mack,
>
> The patch 5fc8dd5c84fc: "kdbus: add connection, queue handling and
> message validation code" from Sep 11, 2014, leads to the following
> static checker warning:
>
> ipc/kdbus/connection.c:2000 kdbus_cmd_send()
> warn: 'cancel_fd' isn't an ERR_PTR
>
> ipc/kdbus/connection.c
> 1998 if (argv[1].item) {
> 1999 cancel_fd = fget(argv[1].item->fds[0]);
> ^^^^
> fget() returns NULL on error.
Thanks for reporting this! Should be fixed with the patch I just sent out.
Best regards,
Daniel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-17 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-17 18:29 kdbus: add connection, queue handling and message validation code Dan Carpenter
2015-03-17 18:49 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).