* [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time()
@ 2015-03-15 10:49 Dan Carpenter
2015-03-23 1:46 ` Chanwoo Choi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-03-15 10:49 UTC (permalink / raw)
To: MyungJoo Ham; +Cc: Chanwoo Choi, linux-kernel, kernel-janitors
"ret" holds negative error codes and zero so it should be signed.
Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
index 598a017..a3f80ca 100644
--- a/drivers/extcon/extcon-max77843.c
+++ b/drivers/extcon/extcon-max77843.c
@@ -682,7 +682,7 @@ static int max77843_muic_set_debounce_time(struct max77843_muic_info *info,
enum max77843_muic_adc_debounce_time time)
{
struct max77843 *max77843 = info->max77843;
- unsigned int ret;
+ int ret;
switch (time) {
case MAX77843_DEBOUNCE_TIME_5MS:
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time()
2015-03-15 10:49 [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time() Dan Carpenter
@ 2015-03-23 1:46 ` Chanwoo Choi
0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2015-03-23 1:46 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, linux-kernel, kernel-janitors
Hi Dan,
On 03/15/2015 07:49 PM, Dan Carpenter wrote:
> "ret" holds negative error codes and zero so it should be signed.
>
> Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon-max77843.c b/drivers/extcon/extcon-max77843.c
> index 598a017..a3f80ca 100644
> --- a/drivers/extcon/extcon-max77843.c
> +++ b/drivers/extcon/extcon-max77843.c
> @@ -682,7 +682,7 @@ static int max77843_muic_set_debounce_time(struct max77843_muic_info *info,
> enum max77843_muic_adc_debounce_time time)
> {
> struct max77843 *max77843 = info->max77843;
> - unsigned int ret;
> + int ret;
>
> switch (time) {
> case MAX77843_DEBOUNCE_TIME_5MS:
>
Applied it on extcon-next branch.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 1:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-15 10:49 [patch 1/2] extcon: max77843: signedness bug in max77843_muic_set_debounce_time() Dan Carpenter
2015-03-23 1:46 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).