From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Wed, 08 Apr 2015 11:51:08 +0000 Subject: Re: [patch] ext4 crypto: testing the wrong variable Message-Id: <5525162C.3020808@bfs.de> List-Id: References: <20150408085338.GA8837@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Dan Carpenter , Theodore Ts'o , Michael Halcrow , Andreas Dilger , linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org Am 08.04.2015 11:51, schrieb Julia Lawall: >> void ext4_fname_crypto_free_buffer(void **buf) >> { >> - if (*buf = NULL || IS_ERR(buf)) >> + if (*buf = NULL || IS_ERR(*buf)) > > Why not use IS_ERR_OR_NULL? > > julia why test *buf = NULL ? xfree() can handle this. the question is do programm depend on *buf=NULL. In case of IS_ERR(*buf) *buf will be left unchanged and later prgramms may things there is a buffer available ? > >> return; >> kfree(*buf); >> *buf = NULL; >> -- >> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >