From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Joe Perches <joe@perches.com>, Chanwoo Choi <cw00.choi@samsung.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] regulator: max77686: fix gpio_enabled shift wrapping bug
Date: Tue, 19 May 2015 00:16:26 +0000 [thread overview]
Message-ID: <555A80DA.5030700@samsung.com> (raw)
In-Reply-To: <1431968463.2870.34.camel@perches.com>
On 19.05.2015 02:01, Joe Perches wrote:
> The code should handle more than 32 bits here because "id"
> can be a value up to MAX77686_REGULATORS (currently 34).
>
> Convert the gpio_enabled type to DECLARE_BITMAP and use
> test_bit/set_bit.
>
> Fixes: 3307e9025d29 ("regulator: max77686: Add GPIO control")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Again - why you do not add CC-stable? If you need observational bug
effect to the commit message you can add:
<<When max77686 regulator was configured to GPIO controlled mode, the
overflow of 32 bit regulator ID could switch off completely different
regulators. This could happen because for other regulators the value of
"GPIO controlled mode" means "disabled".>>
Although I did not saw such effect of overflow in testing, it actually
should happen looking at the code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-05-19 0:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 9:25 [patch] regulator: max77686: fix a shift wrapping bug Dan Carpenter
2015-05-15 10:12 ` Krzysztof Kozlowski
2015-05-15 10:19 ` Chanwoo Choi
2015-05-15 17:10 ` Joe Perches
2015-05-16 0:27 ` Krzysztof Kozlowski
2015-05-18 9:22 ` Dan Carpenter
2015-05-18 17:01 ` [PATCH] regulator: max77686: fix gpio_enabled " Joe Perches
2015-05-19 0:16 ` Krzysztof Kozlowski [this message]
2015-05-20 18:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A80DA.5030700@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).