From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Lambert Date: Thu, 28 May 2015 13:59:50 +0000 Subject: Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups Message-Id: <55671F56.6080402@gmail.com> List-Id: References: <1432817307-28380-1-git-send-email-lambert.quentin@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takashi Iwai Cc: Johannes Berg , Jaroslav Kysela , linuxppc-dev@lists.ozlabs.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On 28/05/2015 15:52, Takashi Iwai wrote: > At Thu, 28 May 2015 14:48:27 +0200, > Quentin Lambert wrote: >> You should use dev_groups instead of the dev_attrs field of struct >> bus_type. This converts the MDIO bus code to use the correct field. >> >> These modifications were made using Coccinelle. >> >> Signed-off-by: Quentin Lambert > What's wrong with dev_attrs? > (Not offending, I'm just curious where the preference for dev_groups > is referred...) This patch is based on commit 4192c74940e23da727eb02b7b4ee779dde2f670, its message indicates that dev_attrs is going away. Quentin