From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mateusz Kulikowski Date: Sun, 07 Jun 2015 15:49:30 +0000 Subject: Re: [patch] staging: rtl8192e: fix some confusing indenting Message-Id: <5574680A.7090107@gmail.com> List-Id: References: <20150605092406.GC24871@mwanda> In-Reply-To: <20150605092406.GC24871@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On 05.06.2015 11:24, Dan Carpenter wrote: > The indenting here causes a static checker warning: > > drivers/staging/rtl8192e/rtllib_rx.c:626 RxReorderIndicatePacket() > warn: curly braces intended? > > The code is actually correct, it's just that these lines were pushed in > an extra indent level by mistake in 35e33b0468ab ('staging: rtl8192e: > Fix LONG_LINE warnings'). > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c > index 6977f04..2bef1f6 100644 > --- a/drivers/staging/rtl8192e/rtllib_rx.c > +++ b/drivers/staging/rtl8192e/rtllib_rx.c > @@ -623,9 +623,9 @@ static void RxReorderIndicatePacket(struct rtllib_device *ieee, > else > pTS->RxIndicateSeq = 4095 - > (WinSize - (SeqNum + 1)) + 1; > - netdev_dbg(ieee->dev, > - "Window Shift! IndicateSeq: %d, NewSeq: %d\n", > - pTS->RxIndicateSeq, SeqNum); > + netdev_dbg(ieee->dev, > + "Window Shift! IndicateSeq: %d, NewSeq: %d\n", > + pTS->RxIndicateSeq, SeqNum); > } > > /* Indication process. > Ouch, Thanks! I've missed this one. M.