From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 09/12] staging: lustre: obdclass: Use !x to check for kzalloc failure
Date: Sun, 21 Jun 2015 11:58:16 +0000 [thread overview]
Message-ID: <5586A6D8.7040500@bfs.de> (raw)
In-Reply-To: <1434819550-3193-10-git-send-email-Julia.Lawall@lip6.fr>
Am 21.06.2015 12:29, schrieb Julia Lawall:
>>> @@ -885,7 +885,7 @@ static int lmd_parse_mgssec(struct lustr
>>> length = tail - ptr;
>>>
>>> lmd->lmd_mgssec = kzalloc(length + 1, GFP_NOFS);
>>> - if (lmd->lmd_mgssec = NULL)
>>> + if (!lmd->lmd_mgssec)
>>> return -ENOMEM;
>>>
>>> memcpy(lmd->lmd_mgssec, ptr, length);
>> looks like memdup()
>
> kmemdup has the same length for both calls. There is kstrndup, but it
> recalculates the length, which looks unnecessary here.
>
> julia
>
mmh, it seem to be use only while mount,
i am wonderingparsing a comma sperareted list must be commen problem for
all FS (and others) maybe i am looking in thew wrong place, there should be
some helpers available ? are they ?
re,
wh
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
next prev parent reply other threads:[~2015-06-21 11:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 16:58 [PATCH 00/12] Use !x to check for kzalloc failure Julia Lawall
2015-06-20 16:58 ` [PATCH 01/12] staging: lustre: fid: " Julia Lawall
2015-06-23 8:25 ` Dilger, Andreas
2015-06-23 9:23 ` Dan Carpenter
2015-06-23 9:35 ` Julia Lawall
2015-06-23 9:57 ` Dan Carpenter
2015-06-23 10:51 ` Julia Lawall
2015-06-24 20:14 ` [lustre-devel] " Simmons, James A.
2015-06-23 22:03 ` Joe Perches
2015-06-23 22:11 ` Joe Perches
2015-06-28 6:52 ` LIBCFS_ALLOC Julia Lawall
2015-06-28 21:54 ` LIBCFS_ALLOC Dan Carpenter
2015-06-30 14:56 ` LIBCFS_ALLOC Simmons, James A.
2015-06-30 15:01 ` LIBCFS_ALLOC Julia Lawall
2015-07-02 22:25 ` [lustre-devel] LIBCFS_ALLOC Simmons, James A.
2015-07-03 11:52 ` Dilger, Andreas
2015-06-30 17:38 ` LIBCFS_ALLOC Dan Carpenter
2015-06-30 21:26 ` [lustre-devel] LIBCFS_ALLOC Dilger, Andreas
2015-06-20 16:59 ` [PATCH 02/12] staging: lustre: fld: Use !x to check for kzalloc failure Julia Lawall
2015-06-20 16:59 ` [PATCH 03/12] staging: lustre: lclient: " Julia Lawall
2015-06-20 16:59 ` [PATCH 04/12] staging: lustre: ldlm: " Julia Lawall
2015-06-20 16:59 ` [PATCH 05/12] staging: lustre: lmv: " Julia Lawall
2015-06-20 16:59 ` [PATCH 06/12] staging: lustre: lov: " Julia Lawall
2015-06-20 16:59 ` [PATCH 07/12] staging: lustre: mdc: " Julia Lawall
2015-06-20 16:59 ` [PATCH 08/12] staging: lustre: mgc: " Julia Lawall
2015-06-20 16:59 ` [PATCH 09/12] staging: lustre: obdclass: " Julia Lawall
2015-06-21 10:02 ` walter harms
2015-06-21 10:29 ` Julia Lawall
2015-06-21 11:58 ` walter harms [this message]
2015-06-20 16:59 ` [PATCH 10/12] staging: lustre: obdecho: " Julia Lawall
2015-06-20 16:59 ` [PATCH 11/12] staging: lustre: osc: " Julia Lawall
2015-06-20 16:59 ` [PATCH 12/12] staging: lustre: ptlrpc: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5586A6D8.7040500@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox