From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Branden Date: Wed, 03 Feb 2021 19:15:35 +0000 Subject: Re: [PATCH] misc: bcm-vk: Fix a couple error codes in probe() Message-Id: <55880105-a097-0268-de54-478d7dbae084@broadcom.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Arnd Bergmann , Greg Kroah-Hartman , Desmond Yan , Olof Johansson , James Hu , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Thanks Dan, On 2021-02-03 6:42 a.m., Dan Carpenter wrote: > These errors should return negative error codes instead of returning > success. Do you have a script running to report such issues or just manually reviewing to find such paths? > > Fixes: 064ffc7c3939 ("misc: bcm-vk: add autoload support") > Fixes: 522f692686a7 ("misc: bcm-vk: add Broadcom VK driver") > Signed-off-by: Dan Carpenter Acked-by: Scott Branden > --- > drivers/misc/bcm-vk/bcm_vk_dev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c > index c3d2bba68ef1..a82a8927d92b 100644 > --- a/drivers/misc/bcm-vk/bcm_vk_dev.c > +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c > @@ -1358,6 +1358,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > vk->bar[i] = pci_ioremap_bar(pdev, i * 2); > if (!vk->bar[i]) { > dev_err(dev, "failed to remap BAR%d\n", i); > + err = -ENOMEM; > goto err_iounmap; > } > } > @@ -1463,7 +1464,8 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > boot_status = vkread32(vk, BAR_0, BAR_BOOT_STATUS); > if (auto_load) { > if ((boot_status & BOOT_STATE_MASK) = BROM_RUNNING) { > - if (bcm_vk_trigger_autoload(vk)) > + err = bcm_vk_trigger_autoload(vk); > + if (err) > goto err_bcm_vk_tty_exit; > } else { > dev_err(dev,