From: Asai Thambi SP <asamymuthupa@micron.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: mtip32xx: fix crash on surprise removal of the drive
Date: Mon, 22 Jun 2015 17:24:51 +0000 [thread overview]
Message-ID: <558844E3.9090106@micron.com> (raw)
In-Reply-To: <20150620123829.GA24933@mwanda>
On 6/20/2015 5:38 AM, Dan Carpenter wrote:
> Hello Asai Thambi SP,
>
> The patch 2132a544727e: "mtip32xx: fix crash on surprise removal of
> the drive" from May 11, 2015, leads to the following static checker
> warning:
>
> drivers/block/mtip32xx/mtip32xx.c:4489 mtip_pci_remove()
> warn: 'dd' was already freed.
Thanks Dan.
We got this report as soon as patch was merged. We are testing the fix and if everything ok, will send out a patch today.
> drivers/block/mtip32xx/mtip32xx.c
> 4484 spin_lock_irqsave(&dev_lock, flags);
> 4485 list_del_init(&dd->remove_list);
> 4486 spin_unlock_irqrestore(&dev_lock, flags);
> 4487
> 4488 kfree(dd);
> ^^
> 4489 set_bit(MTIP_DDF_REMOVE_DONE_BIT, &dd->dd_flag);
> ^^^^^^^^^^^
> 4490
> 4491 pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> 4492 pci_set_drvdata(pdev, NULL);
> 4493 }
>
> regards,
> dan carpenter
--
Regards,
Asai
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
next prev parent reply other threads:[~2015-06-22 17:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-20 12:38 mtip32xx: fix crash on surprise removal of the drive Dan Carpenter
2015-06-22 17:24 ` Asai Thambi SP [this message]
2015-06-23 7:37 ` Dan Carpenter
2015-06-23 8:11 ` Julia Lawall
2015-06-23 9:00 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558844E3.9090106@micron.com \
--to=asamymuthupa@micron.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox