From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 26 Jun 2015 15:48:03 +0000 Subject: Re: [osd-dev] [PATCH 1/1] exofs: Deletion of an unnecessary check before the function call "ore_put_ Message-Id: <558D7433.6030304@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546B0D08.2070305@users.sourceforge.net> <546B0DBB.7080000@gmail.com> In-Reply-To: <546B0DBB.7080000@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Boaz Harrosh , Benny Halevy Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Boaz Harrosh >> From: Markus Elfring >> Date: Tue, 18 Nov 2014 10:05:19 +0100 >> >> The ore_put_io_state() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> fs/exofs/ore_raid.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c >> index 84529b8..5dc7c4c 100644 >> --- a/fs/exofs/ore_raid.c >> +++ b/fs/exofs/ore_raid.c >> @@ -716,6 +716,5 @@ void _ore_free_raid_stuff(struct ore_io_state *ios) >> if (ios->extra_part_alloc) >> kfree(ios->per_dev[0].sglist); >> } >> - if (ios->ios_read_4_write) >> - ore_put_io_state(ios->ios_read_4_write); >> + ore_put_io_state(ios->ios_read_4_write); >> } >> > > Thanks will submit for next Kernel Is this small update suggestion still in the waiting queue for further software improvements? Regards, Markus