From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 27 Jun 2015 16:38:34 +0000 Subject: Re: [PATCH] agp/intel-gtt: Deletion of unnecessary checks before the function call "pci_dev_put" Message-Id: <558ED18A.7030407@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546C9B12.5070800@users.sourceforge.net> In-Reply-To: <546C9B12.5070800@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall > From: Markus Elfring > Date: Wed, 19 Nov 2014 14:24:20 +0100 > > The pci_dev_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > drivers/char/agp/intel-gtt.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c > index 9a024f8..db5877e 100644 > --- a/drivers/char/agp/intel-gtt.c > +++ b/drivers/char/agp/intel-gtt.c > @@ -1434,10 +1434,8 @@ void intel_gmch_remove(void) > if (--intel_private.refcount) > return; > > - if (intel_private.pcidev) > - pci_dev_put(intel_private.pcidev); > - if (intel_private.bridge_dev) > - pci_dev_put(intel_private.bridge_dev); > + pci_dev_put(intel_private.pcidev); > + pci_dev_put(intel_private.bridge_dev); > intel_private.driver = NULL; > } > EXPORT_SYMBOL(intel_gmch_remove); > Would you like to integrate this update suggestion into a source code repository? Regards, Markus