From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 27 Jun 2015 17:17:35 +0000 Subject: Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls Message-Id: <558EDAAF.30803@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <54D28870.3060400@users.sourceforge.net> <54D329D0.7050006@samsung.com> In-Reply-To: <54D329D0.7050006@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie , Inki Dae , Jingoo Han , Kukjin Kim , Kyungmin Park , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Joonyoung Shim , Julia Lawall , kernel-janitors@vger.kernel.org, LKML >> From: Markus Elfring >> Date: Wed, 4 Feb 2015 21:54:45 +0100 >> >> The functions phy_power_on() and vunmap() perform also input >> parameter validation. Thus the test around their calls is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++---- >> drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- >> 2 files changed, 3 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c >> index 34d46aa..306cf1d 100644 >> --- a/drivers/gpu/drm/exynos/exynos_dp_core.c >> +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c >> @@ -1057,14 +1057,12 @@ static int exynos_dp_create_connector(struct exynos_drm_display *display, >> >> static void exynos_dp_phy_init(struct exynos_dp_device *dp) >> { >> - if (dp->phy) >> - phy_power_on(dp->phy); >> + phy_power_on(dp->phy); >> } >> >> static void exynos_dp_phy_exit(struct exynos_dp_device *dp) >> { >> - if (dp->phy) >> - phy_power_off(dp->phy); >> + phy_power_off(dp->phy); >> } >> >> static void exynos_dp_poweron(struct exynos_drm_display *display) >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c >> index e12ea90..0dd448a 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c >> @@ -313,7 +313,7 @@ static void exynos_drm_fbdev_destroy(struct drm_device *dev, >> struct exynos_drm_gem_obj *exynos_gem_obj = exynos_fbd->exynos_gem_obj; >> struct drm_framebuffer *fb; >> >> - if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr) >> + if (is_drm_iommu_supported(dev)) >> vunmap(exynos_gem_obj->buffer->kvaddr); >> >> /* release drm framebuffer and real buffer */ >> > > Acked-by: Joonyoung Shim Do the chances increase to integrate this update suggestion into another source code repository? Regards, Markus