* [PATCH v2 1/3] Staging: Android: Fixes TODO file [not found] <5593E73F.5050607@zoho.com> @ 2015-07-01 13:56 ` Sohny Thomas 2015-07-01 14:13 ` Frans Klaver ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Sohny Thomas @ 2015-07-01 13:56 UTC (permalink / raw) To: gregkh, arve, riandrews, sumit.semwal, carlos Cc: linux-kernel@vger.kernel.org, kernel-janitors - removed non-existent issue from TODO file kuid_t or uid_t not present in staging/android Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> --- drivers/staging/android/TODO | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index 06954cd..b15fb0d 100644 --- a/drivers/staging/android/TODO +++ b/drivers/staging/android/TODO @@ -5,13 +5,6 @@ TODO: - make sure things build as modules properly - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane - - kuid_t should never be exposed to user space as it is - kernel internal type. Data structure for this kuid_t is: - typedef struct { - uid_t val; - } kuid_t; - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 - - ("staging: android: logger: use kuid_t instead of uid_t") Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: Brian Swetland <swetland@google.com> ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file 2015-07-01 13:56 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas @ 2015-07-01 14:13 ` Frans Klaver 2015-07-01 15:58 ` Sohny Thomas 2015-07-01 14:27 ` Dan Carpenter 2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas 2 siblings, 1 reply; 9+ messages in thread From: Frans Klaver @ 2015-07-01 14:13 UTC (permalink / raw) To: Sohny Thomas Cc: Greg KH, arve, riandrews, Sumit Semwal, carlos, linux-kernel@vger.kernel.org, kernel-janitors On Wed, Jul 1, 2015 at 3:44 PM, Sohny Thomas <sohnythomas@zoho.com> wrote: > > - removed non-existent issue from TODO file > kuid_t or uid_t not present in staging/android > > Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> s,-of-,-off-, You can remove the leading dash (-). Could you elaborate on why this issue is non existent? Thanks, Frans ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file 2015-07-01 14:13 ` Frans Klaver @ 2015-07-01 15:58 ` Sohny Thomas 0 siblings, 0 replies; 9+ messages in thread From: Sohny Thomas @ 2015-07-01 15:58 UTC (permalink / raw) To: Frans Klaver Cc: Greg KH, arve, riandrews, Sumit Semwal, carlos, linux-kernel@vger.kernel.org, kernel-janitors On Wednesday 01 July 2015 07:43 PM, Frans Klaver wrote: > On Wed, Jul 1, 2015 at 3:44 PM, Sohny Thomas <sohnythomas@zoho.com> wrote: >> >> - removed non-existent issue from TODO file >> kuid_t or uid_t not present in staging/android >> >> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> > > s,-of-,-off-, > > You can remove the leading dash (-). Could you elaborate on why this > issue is non existent? Thanks for catching the off. According to the TODO the kuid_t is not present in any files under staging/android So I said its non-existent > > Thanks, > Frans > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file 2015-07-01 13:56 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas 2015-07-01 14:13 ` Frans Klaver @ 2015-07-01 14:27 ` Dan Carpenter 2015-07-01 15:50 ` Sohny Thomas 2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas 2 siblings, 1 reply; 9+ messages in thread From: Dan Carpenter @ 2015-07-01 14:27 UTC (permalink / raw) To: Sohny Thomas Cc: gregkh, arve, riandrews, sumit.semwal, carlos, linux-kernel@vger.kernel.org, kernel-janitors On Wed, Jul 01, 2015 at 07:14:38PM +0530, Sohny Thomas wrote: > > - removed non-existent issue from TODO file > kuid_t or uid_t not present in staging/android > > Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> The patch is all mangled. It barely seems to match the description but I can't tell for sure because of the mangling. regards, dan carpenter ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] Staging: Android: Fixes TODO file 2015-07-01 14:27 ` Dan Carpenter @ 2015-07-01 15:50 ` Sohny Thomas 0 siblings, 0 replies; 9+ messages in thread From: Sohny Thomas @ 2015-07-01 15:50 UTC (permalink / raw) To: Dan Carpenter Cc: gregkh, arve, riandrews, sumit.semwal, carlos, linux-kernel@vger.kernel.org, kernel-janitors On Wednesday 01 July 2015 07:57 PM, Dan Carpenter wrote: > On Wed, Jul 01, 2015 at 07:14:38PM +0530, Sohny Thomas wrote: >> >> - removed non-existent issue from TODO file >> kuid_t or uid_t not present in staging/android >> >> Signed-of-by: Sohny Thomas <sohnythomas@zoho.com> > > > The patch is all mangled. It barely seems to match the description but > I can't tell for sure because of the mangling. I sent an another version, Hope its not mangled now Thanks for your time. -Sohny > > regards, > dan carpenter > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 ] Staging: Android: Fixes for TODO file 2015-07-01 13:56 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas 2015-07-01 14:13 ` Frans Klaver 2015-07-01 14:27 ` Dan Carpenter @ 2015-07-01 15:49 ` Sohny Thomas 2015-07-14 22:50 ` Greg KH ` (2 more replies) 2 siblings, 3 replies; 9+ messages in thread From: Sohny Thomas @ 2015-07-01 15:49 UTC (permalink / raw) To: gregkh, arve, riandrews, sumit.semwal, carlos Cc: linux-kernel@vger.kernel.org, kernel-janitors Removed non-existent issue from TODO file No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory Signed-off-by: Sohny Thomas <sohnythomas@zoho.com> --- drivers/staging/android/TODO | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index 06954cd..b15fb0d 100644 --- a/drivers/staging/android/TODO +++ b/drivers/staging/android/TODO @@ -5,13 +5,6 @@ TODO: - make sure things build as modules properly - add proper arch dependencies as needed - audit userspace interfaces to make sure they are sane - - kuid_t should never be exposed to user space as it is - kernel internal type. Data structure for this kuid_t is: - typedef struct { - uid_t val; - } kuid_t; - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 - - ("staging: android: logger: use kuid_t instead of uid_t") Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: Brian Swetland <swetland@google.com> -- ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 ] Staging: Android: Fixes for TODO file 2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas @ 2015-07-14 22:50 ` Greg KH 2015-07-18 8:48 ` Sohny Thomas 2015-07-18 11:30 ` Julia Lawall 2 siblings, 0 replies; 9+ messages in thread From: Greg KH @ 2015-07-14 22:50 UTC (permalink / raw) To: Sohny Thomas Cc: arve, riandrews, sumit.semwal, carlos, linux-kernel@vger.kernel.org, kernel-janitors On Wed, Jul 01, 2015 at 09:19:11PM +0530, Sohny Thomas wrote: > Removed non-existent issue from TODO file > No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory > > Signed-off-by: Sohny Thomas <sohnythomas@zoho.com> > --- > drivers/staging/android/TODO | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO > index 06954cd..b15fb0d 100644 > --- a/drivers/staging/android/TODO > +++ b/drivers/staging/android/TODO > @@ -5,13 +5,6 @@ TODO: > - make sure things build as modules properly > - add proper arch dependencies as needed > - audit userspace interfaces to make sure they are sane > - - kuid_t should never be exposed to user space as it is > - kernel internal type. Data structure for this kuid_t is: > - typedef struct { > - uid_t val; > - } kuid_t; > - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 > - - ("staging: android: logger: use kuid_t instead of uid_t") > > Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: > Brian Swetland <swetland@google.com> Doesn't apply to the tree :( ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 ] Staging: Android: Fixes for TODO file 2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas 2015-07-14 22:50 ` Greg KH @ 2015-07-18 8:48 ` Sohny Thomas 2015-07-18 11:30 ` Julia Lawall 2 siblings, 0 replies; 9+ messages in thread From: Sohny Thomas @ 2015-07-18 8:48 UTC (permalink / raw) To: kernel-janitors On Wednesday 15 July 2015 04:20 AM, Greg KH wrote: > On Wed, Jul 01, 2015 at 09:19:11PM +0530, Sohny Thomas wrote: >> Removed non-existent issue from TODO file >> No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory >> >> Signed-off-by: Sohny Thomas <sohnythomas@zoho.com> >> --- >> drivers/staging/android/TODO | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO >> index 06954cd..b15fb0d 100644 >> --- a/drivers/staging/android/TODO >> +++ b/drivers/staging/android/TODO >> @@ -5,13 +5,6 @@ TODO: >> - make sure things build as modules properly >> - add proper arch dependencies as needed >> - audit userspace interfaces to make sure they are sane >> - - kuid_t should never be exposed to user space as it is >> - kernel internal type. Data structure for this kuid_t is: >> - typedef struct { >> - uid_t val; >> - } kuid_t; >> - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 >> - - ("staging: android: logger: use kuid_t instead of uid_t") >> >> Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: >> Brian Swetland <swetland@google.com> > > Doesn't apply to the tree :( Uh, Sorry to reply late, you mean this snippet is not part of the tree? > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 ] Staging: Android: Fixes for TODO file 2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas 2015-07-14 22:50 ` Greg KH 2015-07-18 8:48 ` Sohny Thomas @ 2015-07-18 11:30 ` Julia Lawall 2 siblings, 0 replies; 9+ messages in thread From: Julia Lawall @ 2015-07-18 11:30 UTC (permalink / raw) To: kernel-janitors On Sat, 18 Jul 2015, Sohny Thomas wrote: > > > On Wednesday 15 July 2015 04:20 AM, Greg KH wrote: > > On Wed, Jul 01, 2015 at 09:19:11PM +0530, Sohny Thomas wrote: > >> Removed non-existent issue from TODO file > >> No instance of kuid_t or uid_t as mentioned by the file is present in staging/android directory > >> > >> Signed-off-by: Sohny Thomas <sohnythomas@zoho.com> > >> --- > >> drivers/staging/android/TODO | 7 ------- > >> 1 file changed, 7 deletions(-) > >> > >> diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO > >> index 06954cd..b15fb0d 100644 > >> --- a/drivers/staging/android/TODO > >> +++ b/drivers/staging/android/TODO > >> @@ -5,13 +5,6 @@ TODO: > >> - make sure things build as modules properly > >> - add proper arch dependencies as needed > >> - audit userspace interfaces to make sure they are sane > >> - - kuid_t should never be exposed to user space as it is > >> - kernel internal type. Data structure for this kuid_t is: > >> - typedef struct { > >> - uid_t val; > >> - } kuid_t; > >> - - This bug is introduced by Xiong Zhou in the patch bd471258f2e09 > >> - - ("staging: android: logger: use kuid_t instead of uid_t") > >> > >> Please send patches to Greg Kroah-Hartman <greg@kroah.com> and Cc: > >> Brian Swetland <swetland@google.com> > > > > Doesn't apply to the tree :( > Uh, Sorry to reply late, you mean this snippet is not part of the tree? It means something has changed in the code you have modified, and you need to redo the patch in some way so that it applies to the latest version. julia ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-07-18 11:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5593E73F.5050607@zoho.com>
2015-07-01 13:56 ` [PATCH v2 1/3] Staging: Android: Fixes TODO file Sohny Thomas
2015-07-01 14:13 ` Frans Klaver
2015-07-01 15:58 ` Sohny Thomas
2015-07-01 14:27 ` Dan Carpenter
2015-07-01 15:50 ` Sohny Thomas
2015-07-01 15:49 ` [PATCH v3 ] Staging: Android: Fixes for " Sohny Thomas
2015-07-14 22:50 ` Greg KH
2015-07-18 8:48 ` Sohny Thomas
2015-07-18 11:30 ` Julia Lawall
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).