From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 01 Aug 2015 10:40:38 +0000 Subject: Re: [PATCH 03/11] ocfs2: Less checks in ocfs2_rename() after error detection Message-Id: <55BCA226.2020401@users.sourceforge.net> List-Id: References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <5455FC05.4010606@users.sourceforge.net> <55992DF0.5030205@users.sourceforge.net> <55993170.6060306@users.sourceforge.net> <20150706085414.GD28762@mwanda> In-Reply-To: <20150706085414.GD28762@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Joel Becker , Mark Fasheh , ocfs2-devel@oss.oracle.com, LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> From: Markus Elfring >> Date: Sat, 4 Jul 2015 15:30:18 +0200 >> >> Skip checks for a few variables in three error handling cases within >> the ocfs2_rename() function by adjustment of a few jump targets >> according to the Linux coding style convention. >> >> Signed-off-by: Markus Elfring > > I don't think this is an improvement. How do you think about the other update suggestions from this patch series? Can the corresponding source code review be continued? Regards, Markus