* [patch] extcon: signedness bugs break error handling
@ 2015-08-04 7:47 Dan Carpenter
2015-08-04 8:40 ` Roger Quadros
2015-08-04 10:56 ` Chanwoo Choi
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-08-04 7:47 UTC (permalink / raw)
To: MyungJoo Ham, Roger Quadros; +Cc: Chanwoo Choi, linux-kernel, kernel-janitors
Unsigned is never less than zero so this error handling won't work.
Fixes: be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 8301a72..da2fb6c 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
{
- unsigned int id;
+ int id;
if (edev->max_supported = 0)
return -EINVAL;
@@ -379,7 +379,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_);
*/
int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name)
{
- unsigned int id;
+ int id;
id = find_cable_id_by_name(edev, cable_name);
if (id < 0)
@@ -430,7 +430,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_);
int extcon_set_cable_state(struct extcon_dev *edev,
const char *cable_name, bool cable_state)
{
- unsigned int id;
+ int id;
id = find_cable_id_by_name(edev, cable_name);
if (id < 0)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] extcon: signedness bugs break error handling
2015-08-04 7:47 [patch] extcon: signedness bugs break error handling Dan Carpenter
@ 2015-08-04 8:40 ` Roger Quadros
2015-08-04 10:56 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Roger Quadros @ 2015-08-04 8:40 UTC (permalink / raw)
To: Dan Carpenter, MyungJoo Ham; +Cc: Chanwoo Choi, linux-kernel, kernel-janitors
On 04/08/15 10:47, Dan Carpenter wrote:
> Unsigned is never less than zero so this error handling won't work.
>
> Fixes: be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan.
Reviewed-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 8301a72..da2fb6c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
>
> static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
> {
> - unsigned int id;
> + int id;
>
> if (edev->max_supported = 0)
> return -EINVAL;
> @@ -379,7 +379,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_);
> */
> int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name)
> {
> - unsigned int id;
> + int id;
>
> id = find_cable_id_by_name(edev, cable_name);
> if (id < 0)
> @@ -430,7 +430,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_);
> int extcon_set_cable_state(struct extcon_dev *edev,
> const char *cable_name, bool cable_state)
> {
> - unsigned int id;
> + int id;
>
> id = find_cable_id_by_name(edev, cable_name);
> if (id < 0)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] extcon: signedness bugs break error handling
2015-08-04 7:47 [patch] extcon: signedness bugs break error handling Dan Carpenter
2015-08-04 8:40 ` Roger Quadros
@ 2015-08-04 10:56 ` Chanwoo Choi
1 sibling, 0 replies; 3+ messages in thread
From: Chanwoo Choi @ 2015-08-04 10:56 UTC (permalink / raw)
To: Dan Carpenter; +Cc: MyungJoo Ham, Roger Quadros, linux-kernel, kernel-janitors
On 08/04/2015 04:47 PM, Dan Carpenter wrote:
> Unsigned is never less than zero so this error handling won't work.
>
> Fixes: be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 8301a72..da2fb6c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
>
Applied it.
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-04 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-04 7:47 [patch] extcon: signedness bugs break error handling Dan Carpenter
2015-08-04 8:40 ` Roger Quadros
2015-08-04 10:56 ` Chanwoo Choi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).