From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Date: Sun, 23 Aug 2015 01:41:12 +0000 Subject: Re: [patch] qla4xxx: remove some bogus casts Message-Id: <55D924B8.3090407@sandisk.com> List-Id: References: <20150817143647.GA23820@mwanda> <55D2B879.7040906@sandisk.com> <20150818084726.GG5610@mwanda> In-Reply-To: <20150818084726.GG5610@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: QLogic-Storage-Upstream@qlogic.com, Vikas Chaudhary , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org On 08/18/15 01:47, Dan Carpenter wrote: > On Mon, Aug 17, 2015 at 09:45:45PM -0700, Bart Van Assche wrote: >> On 08/17/2015 07:36 AM, Dan Carpenter wrote: >>> These casts are wrong and unnecessary. They annoy static checkers >>> because they imply we are planning to write sizeof(long) bytes to a >>> sizeof(u32) buffer which would corrupt memory. >> >> Hello Dan, >> >> Can you verify whether that patch is still needed after having >> applied the patch series I posted in July (and that was acknowledged >> by QLogic): http://thread.gmane.org/gmane.linux.scsi/103135 ? >> > > I think it is needed still? Hello Dan, You are right, this patch is indeed needed. Hence: Reviewed-by: Bart Van Assche