From: Doug Ledford <dledford@redhat.com>
To: "ira.weiny" <ira.weiny@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: Matan Barak <matanb@mellanox.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Haggai Eran <haggaie@mellanox.com>,
Moni Shoua <monis@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] IB/core: off by one in error handling
Date: Sat, 29 Aug 2015 03:59:55 +0000 [thread overview]
Message-ID: <55E12E3B.7030102@redhat.com> (raw)
In-Reply-To: <20150829011800.GB2713@phlsvsds.ph.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]
On 08/28/2015 09:18 PM, ira.weiny wrote:
> On Tue, Aug 18, 2015 at 12:23:17PM +0300, Dan Carpenter wrote:
>> This is a zero offset array. The current code could try to free random
>> memory and crash. Also it leaks the first element.
>>
>> Fixes: 230145ff8124 ('IB/core: Add RoCE GID table management')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> I don't actually see this in Dougs to-be-rebased/for-4.3 tree.
>
> Looks like Doug picked up a different version of the patch in the latest
> rebase.
>
> annotating cache.c I see a different change from Matan in commit
>
> 76680c1cfc5ab
>
> +rollback_table_setup:
> + for (port = 0; port < ib_dev->phys_port_cnt; port++) {
> + cleanup_gid_table_port(ib_dev, port + rdma_start_port(ib_dev),
> + table[port]);
> + release_gid_table(table[port]);
> + }
>
> Ira
Correct, so I dropped this patch.
>>
>> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
>> index a9d5c70..f5d14a7 100644
>> --- a/drivers/infiniband/core/cache.c
>> +++ b/drivers/infiniband/core/cache.c
>> @@ -582,7 +582,7 @@ static int _gid_table_setup_one(struct ib_device *ib_dev)
>> return 0;
>>
>> rollback_table_setup:
>> - for (port = 1; port <= ib_dev->phys_port_cnt; port++)
>> + for (port = 0; port < ib_dev->phys_port_cnt; port++)
>> free_gid_table(ib_dev, port, table[port]);
>>
>> kfree(table);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2015-08-29 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 9:23 [patch] IB/core: off by one in error handling Dan Carpenter
2015-08-29 1:18 ` ira.weiny
2015-08-29 3:59 ` Doug Ledford [this message]
2015-09-03 17:39 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E12E3B.7030102@redhat.com \
--to=dledford@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=ira.weiny@intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=monis@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).