From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed Cashin <ed.cashin@acm.org>
Date: Tue, 15 Sep 2015 01:39:01 +0000
Subject: Re: [PATCH 09/39] aoe: drop null test before destroy functions
Message-Id: <55F776B5.2090203@acm.org>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1442146532-9100-1-git-send-email-Julia.Lawall@lip6.fr> <1442146532-9100-10-git-send-email-Julia.Lawall@lip6.fr>
In-Reply-To: <1442146532-9100-10-git-send-email-Julia.Lawall@lip6.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: sergey.senozhatsky@gmail.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org

ACK.  Thanks.

On 09/13/2015 08:15 AM, Julia Lawall wrote:
> Remove unneeded NULL test.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ expression x; @@
> -if (x != NULL)
>    \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>   drivers/block/aoe/aoedev.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
> index ffd1947..efc8a8a 100644
> --- a/drivers/block/aoe/aoedev.c
> +++ b/drivers/block/aoe/aoedev.c
> @@ -285,8 +285,7 @@ freedev(struct aoedev *d)
>   	e = t + d->ntargets;
>   	for (; t < e && *t; t++)
>   		freetgt(d, *t);
> -	if (d->bufpool)
> -		mempool_destroy(d->bufpool);
> +	mempool_destroy(d->bufpool);
>   	skbpoolfree(d);
>   	minor_free(d->sysminor);
>   
>