kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures
@ 2015-10-11 12:18 Julia Lawall
  2015-10-12  0:51 ` Ben Skeggs
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2015-10-11 12:18 UTC (permalink / raw)
  To: David Airlie; +Cc: kernel-janitors, linux-kernel, dri-devel

These nvkm_object_func structures are never modified.  All other
nvkm_object_func structures are declared as const.

Done with the help of Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c |    2 +-
 drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c       |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c
index 62d3fb6..2be8463 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c
@@ -109,7 +109,7 @@ nv04_disp_mthd(struct nvkm_object *object, u32 mthd, void *data, u32 size)
 	return -EINVAL;
 }
 
-static struct nvkm_object_func
+static const struct nvkm_object_func
 nv04_disp_root = {
 	.mthd = nv04_disp_mthd,
 	.ntfy = nvkm_disp_ntfy,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
index 0db9be2..2721592 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
@@ -633,7 +633,7 @@ nvkm_perfmon_dtor(struct nvkm_object *object)
 	return perfmon;
 }
 
-static struct nvkm_object_func
+static const struct nvkm_object_func
 nvkm_perfmon = {
 	.dtor = nvkm_perfmon_dtor,
 	.mthd = nvkm_perfmon_mthd,


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures
  2015-10-11 12:18 [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures Julia Lawall
@ 2015-10-12  0:51 ` Ben Skeggs
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Skeggs @ 2015-10-12  0:51 UTC (permalink / raw)
  To: Julia Lawall, David Airlie; +Cc: kernel-janitors, linux-kernel, dri-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 10/11/2015 10:18 PM, Julia Lawall wrote:
> These nvkm_object_func structures are never modified.  All other 
> nvkm_object_func structures are declared as const.
> 
> Done with the help of Coccinelle.
I've picked up the patch, thanks!

Ben.

> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> --- drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c |    2 +- 
> drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c       |    2 +- 2
> files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c index
> 62d3fb6..2be8463 100644 ---
> a/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c +++
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv04.c @@ -109,7
> +109,7 @@ nv04_disp_mthd(struct nvkm_object *object, u32 mthd, void
> *data, u32 size) return -EINVAL; }
> 
> -static struct nvkm_object_func +static const struct
> nvkm_object_func nv04_disp_root = { .mthd = nv04_disp_mthd, .ntfy > nvkm_disp_ntfy, diff --git
> a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c index
> 0db9be2..2721592 100644 ---
> a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c +++
> b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c @@ -633,7 +633,7 @@
> nvkm_perfmon_dtor(struct nvkm_object *object) return perfmon; }
> 
> -static struct nvkm_object_func +static const struct
> nvkm_object_func nvkm_perfmon = { .dtor = nvkm_perfmon_dtor, .mthd
> = nvkm_perfmon_mthd,
> 
> _______________________________________________ dri-devel mailing
> list dri-devel@lists.freedesktop.org 
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWGwQdAAoJEHYLnGJQkpH74lsQAMlUrNJ9gRc1d6P6fKcTwVGa
YwBG8R2pg+nQ4UY9GoFvTJO1CSanG+4bLM88ccTDeuF7nIhV9g7Z8vPg8Jy1B2ZX
V7mVvNdO+sagYT6PcitXzDDirM6yoNZLf+7y0I+8HPNwg9TBCXUFZCF0w3DY0Txu
S6HZmCO/rlhQJFGuOsOrfKAtrEwIaw1JiAWMS8VUNbjdzHgozetJQgq7xAoe49A2
GGtQ6b1JtI8bmzYDVhJmhSqzTwBmZO5RLL6Wo3DFta/E6bR6SQgpeU2im9lkwgKH
WOBkotpg/EJJ4ltSMpjOkJlTu5xWEUr12RA5SYlcyWEX7XwnLX7S4TXa8Dh6jIFE
Jv4tnWsKVFrzLKQ/Q75uaFgbhJiWt8VNpfGaLmnnI3qYjujAoXBgiapp7Xi/fd25
vUx1j/OWmKQy3dDdjAQKXDp2MK+DrJig7lfQahwGQRztLwvMv65hq7fXLlt0LbjH
DzU9Q2VzSbEfW02zDcgCem7gIUf+X3cKkMx2c9Bok56cGOybUPm33OFFZ5IE0KJ4
3yRHE5aq2kzeWsN99N/IvyE6WhtK+kCNmEfkddYOvPQ3XioAk1zjNAdkQudM0Ii0
JWjFFVt0fixVOl8zmGIDNFNBnzYKu5SwvA31Usr1Vsltx+c4LXAmIGG6/vey5Uiv
WmpIfcA3EmL2jRoaS/DG
\0y+
-----END PGP SIGNATURE-----

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-12  0:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-11 12:18 [PATCH] drm/nouveau/disp,pm: constify nvkm_object_func structures Julia Lawall
2015-10-12  0:51 ` Ben Skeggs

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).