From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree
Date: Sun, 18 Oct 2015 09:55:38 +0000 [thread overview]
Message-ID: <56236C9A.8060906@users.sourceforge.net> (raw)
In-Reply-To: <1445102605-22408-1-git-send-email-Julia.Lawall@lip6.fr>
> Remove removal and re-addition of freeing functions.
I find such a wording confusing for a commit message.
> Add position variable on usb_free_urb in the non-patch case.
Is it interesting that this fix corresponds to a bug report from 2014-08-09?
https://lkml.org/lkml/2014/8/9/33
https://systeme.lip6.fr/pipermail/cocci/2014-August/001038.html
> @r depends on context || report || org @
> @@ -36,8 +32,8 @@ expression E;
> position p;
> @@
>
> -* if (E)
> -* \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb\)(E);
> +* if (E != NULL)
> +* \(kfree@p\|debugfs_remove@p\|debugfs_remove_recursive@p\|usb_free_urb@p\)(E);
How do you think about to extend the shown function name pattern
also with suffixes like the following (besides "destroy")?
* put
* release
* unref
* unregister
Regards,
Markus
next prev parent reply other threads:[~2015-10-18 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-17 17:23 [PATCH 1/2] coccinelle: ifnullfree: improve and extend ifnullfree Julia Lawall
2015-10-18 9:55 ` SF Markus Elfring [this message]
2015-10-26 21:32 ` Michal Marek
2015-10-26 21:36 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56236C9A.8060906@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).