From: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
To: Dan Carpenter <error27@gmail.com>
Cc: walter harms <wharms@bfs.de>,
Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] w1: off by one in w1_f29_remove_slave()
Date: Wed, 17 Aug 2011 18:42:56 +0000 [thread overview]
Message-ID: <56274C82-8FCA-45F9-B3DC-9863889694AA@gmail.com> (raw)
In-Reply-To: <20110730085131.GE5575@shale.localdomain>
On Jul 30, 2011, at 4:51, Dan Carpenter wrote:
> On Sat, Jul 30, 2011 at 10:42:29AM +0200, walter harms wrote:
>> Is there any reason to release the data "backwards" ?
>> The default way is to go upwards. that looks more readable.
>
> I considered doing it that way. It would work. I throught maybe
> they were going to add something where it needed to be unwound LIFO
> order.
>
> I'll wait for Jean-Françoisto say which way is prefered.
>
Sorry for the delay. Sorry also for the trouble this dummy copy/paste mistake is causing. It's a bit embarrassing even if the intentions are good ;) This second mistake explains why I wasn't getting ill effects from the remove.
The sysfs files were removed backwards as a programmer reflex. In this case it is not really necessary since there are no real dependencies between the function implementations... but there may be in the future. This is why it's a safe habit to do it this way.
I would keep the removal in reverse order, so I will ack the the v2 patch
Cheers!
/jfd
> regards,
> dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-08-17 18:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 9:55 [patch] w1: off by one in w1_f29_remove_slave() Dan Carpenter
2011-07-29 20:28 ` Jean-François Dagenais
[not found] ` <CAOmT4fS1OqQb5KOOeFnGHt1tnYGBRutVrAZ4cXB6n=hou5fn8w@mail.gmail.com>
2011-07-29 22:55 ` Dan Carpenter
2011-07-30 8:19 ` [patch v2] w1: fix for loop " Dan Carpenter
2011-08-17 18:45 ` Jean-Francois Dagenais
2011-07-30 8:42 ` [patch] w1: off by one " walter harms
2011-07-30 8:51 ` Dan Carpenter
2011-08-17 18:42 ` Jean-Francois Dagenais [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56274C82-8FCA-45F9-B3DC-9863889694AA@gmail.com \
--to=jeff.dagenais@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=error27@gmail.com \
--cc=johnpol@2ka.mipt.ru \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox