From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Brace Date: Thu, 12 Nov 2015 15:33:02 +0000 Subject: Re: [patch] hpsa: logical vs bitwise AND typo Message-Id: <5644B12E.4040506@pmcs.com> List-Id: References: <20151112094338.GB28432@mwanda> <1447322361.2616.10.camel@suse.de> In-Reply-To: <1447322361.2616.10.camel@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Johannes Thumshirn , Dan Carpenter , Scott Teel Cc: "James E.J. Bottomley" , iss_storagedev@hp.com, storagedev@pmcs.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org On 11/12/2015 03:59 AM, Johannes Thumshirn wrote: > On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote: >> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was >> intended here instead of logical &&. This bug is essentially >> harmless, >> it means that sometimes we don't print a warning message which we >> wanted >> to print. >> >> Fixes: c2adae44e916 ('hpsa: disable report lun data caching') >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c >> index 6a8f958..a386036 100644 >> --- a/drivers/scsi/hpsa.c >> +++ b/drivers/scsi/hpsa.c >> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct >> ctlr_info *h) >> if ((rc != 0) || (c->err_info->CommandStatus != 0)) >> goto errout; >> >> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) >> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING) >> goto out; >> >> errout: > Reviewed-by: Johannes Thumshirn > >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" >> in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > Signed-off-by: Don Brace > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html