From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Date: Wed, 09 Dec 2015 17:56:37 +0000 Subject: Re: [patch] nvme: precedence bug in nvme_pr_clear() Message-Id: <56686B55.7020900@fb.com> List-Id: References: <20151209102406.GD3173@mwanda> In-Reply-To: <20151209102406.GD3173@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On 12/09/2015 03:24 AM, Dan Carpenter wrote: > The "|" operator has higher precedence than "?:" so this didn't work as > intended. I had previously fixed this bug, but it we copied the older > unfixed version when we moved the function between files. > > Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code') > Signed-off-by: Dan Carpenter Dejavu, but I guess in a different function. Christoph, you are hereby banned from ever using ?:! -- Jens Axboe