From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 11 Dec 2015 18:26:10 +0000 Subject: [PATCH 2/2] z2ram: Delete a jump label in z2_init() Message-Id: <566B1542.7040902@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <566B13C1.50907@users.sourceforge.net> In-Reply-To: <566B13C1.50907@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: LKML , Minchan Kim , Nitin Gupta , Sergey Senozhatsky Cc: kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Fri, 11 Dec 2015 18:48:14 +0100 This issue was detected by using the Coccinelle software. * Let us return directly if a call of the function "register_blkdev" failed. * Remove the jump label "err" then. Signed-off-by: Markus Elfring --- drivers/block/z2ram.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c index 968f9e5..b07581d 100644 --- a/drivers/block/z2ram.c +++ b/drivers/block/z2ram.c @@ -345,9 +345,8 @@ z2_init(void) if (!MACH_IS_AMIGA) return -ENODEV; - ret = -EBUSY; if (register_blkdev(Z2RAM_MAJOR, DEVICE_NAME)) - goto err; + return -EBUSY; ret = -ENOMEM; z2ram_gendisk = alloc_disk(1); @@ -374,7 +373,6 @@ out_queue: put_disk(z2ram_gendisk); out_disk: unregister_blkdev(Z2RAM_MAJOR, DEVICE_NAME); -err: return ret; } -- 2.6.3