From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sat, 26 Dec 2015 19:30:29 +0000 Subject: Re: i2c-core: One function call less in acpi_i2c_space_handler() after error detection Message-Id: <567EEAD5.4060108@users.sourceforge.net> List-Id: References: <201512261449.pmBxYtq3%fengguang.wu@intel.com> <567E3CF3.10606@users.sourceforge.net> <20151226074859.GA905@tetsubishi> <567E553B.5080005@users.sourceforge.net> <20151226184152.GA882@tetsubishi> In-Reply-To: <20151226184152.GA882@tetsubishi> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall >> I would appreciate if an unnecessary function call can be avoided here >> so that the affected exception handling can become also a bit more efficient. > > Simpler code is easier to maintain. There are different opinions available around the desired simplicity. > See your patch, you didn't get it correctly at your first try. I wonder myself about the circumstances on how my incomplete update suggestion did happen. > Also, this is not a hot path, I'm curious if approaches around better exception handling can eventually become a "hot topic". > so I see it as a micro-optimization I can agree to this view for this function implementation. > also adding complexity. There are the usual software development trade-offs. > I don't favor that. Thanks for your constructive feedback. Is an identifier like "free_client" a bit nicer (according to the Linux coding style recommendations) than the short jump label "err" in the discussed use case? Regards, Markus