From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sat, 26 Dec 2015 20:29:09 +0000 [thread overview]
Message-ID: <567EF895.6080702@cogentembedded.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1512262123500.2070@localhost6.localdomain6>
On 12/26/2015 11:24 PM, Julia Lawall wrote:
> The conclusion seems to be that it is useful to override the value, so we
> can just drop this semantic patch.
No! As I said, unconditionally overriding an error value breaks the
deferred probing. It's actually a bug to override it, so the patch seems
*very* useful.
> julia
MBR, Sergei
next prev parent reply other threads:[~2015-12-26 20:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 19:24 [PATCH] coccinelle: api: check for propagation of error from platform_get_irq Julia Lawall
2015-12-26 19:59 ` Sergei Shtylyov
2015-12-26 20:08 ` Julia Lawall
2015-12-26 20:24 ` Julia Lawall
2015-12-26 20:29 ` Sergei Shtylyov [this message]
2015-12-26 20:38 ` Julia Lawall
2015-12-26 20:58 ` [PATCH v2] " Julia Lawall
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:36 ` Sergei Shtylyov
2015-12-27 6:13 ` Julia Lawall
2015-12-27 11:18 ` Sergei Shtylyov
2015-12-27 7:58 ` [Cocci] " SF Markus Elfring
2015-12-27 11:41 ` Julia Lawall
2015-12-27 16:24 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567EF895.6080702@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).