From: SF Markus Elfring <elfring@users.sourceforge.net>
To: cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v2] coccinelle: api: check for propagation of error from platform_get_irq
Date: Sun, 27 Dec 2015 07:58:33 +0000 [thread overview]
Message-ID: <567F9A29.50202@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1512262156580.2070@localhost6.localdomain6>
> The error return value of platform_get_irq seems to often get dropped.
How do you think about any more fine-tuning here?
Commit message:
* … of the platform_get_irq() function seems to get dropped too often.
* Why do you concentrate on a single function name?
Do you plan to extend this source code analysis approach?
> +@script:python r_report depends on report@
> +j0 << r.j0;
> +j1 << r.j1;
> +@@
> +
> +msg = "Propagate return value of platform_get_irq around line %s." % (j1[0].line)
Are there more unchecked return values which are interesting
for further considerations?
https://cwe.mitre.org/data/definitions/252.html
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-27 7:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-26 19:24 [PATCH] coccinelle: api: check for propagation of error from platform_get_irq Julia Lawall
2015-12-26 19:59 ` Sergei Shtylyov
2015-12-26 20:08 ` Julia Lawall
2015-12-26 20:24 ` Julia Lawall
2015-12-26 20:29 ` Sergei Shtylyov
2015-12-26 20:38 ` Julia Lawall
2015-12-26 20:58 ` [PATCH v2] " Julia Lawall
2015-12-26 22:26 ` Sergei Shtylyov
2015-12-26 22:32 ` Julia Lawall
2015-12-26 22:36 ` Sergei Shtylyov
2015-12-27 6:13 ` Julia Lawall
2015-12-27 11:18 ` Sergei Shtylyov
2015-12-27 7:58 ` SF Markus Elfring [this message]
2015-12-27 11:41 ` [Cocci] " Julia Lawall
2015-12-27 16:24 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567F9A29.50202@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).