From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 27 Dec 2015 12:40:13 +0000 Subject: [PATCH 1/2] InfiniBand-iSER: One jump label less in iser_reg_sig_mr() Message-Id: <567FDC2D.2090706@users.sourceforge.net> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <567FDB4E.2040000@users.sourceforge.net> In-Reply-To: <567FDB4E.2040000@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, Doug Ledford , Hal Rosenstock , Or Gerlitz , Roi Dayan , Sagi Grimberg , Sean Hefty Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Sun, 27 Dec 2015 11:41:42 +0100 This issue was detected by using the Coccinelle software. 1. Let us return directly if a call of the iser_set_sig_attrs() function failed. 2. Delete the jump label "err" then. 3. Return zero as a constant at the end. Signed-off-by: Markus Elfring --- drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_memory.c b/drivers/infiniband/ulp/iser/iser_memory.c index ea765fb..14e08b3 100644 --- a/drivers/infiniband/ulp/iser/iser_memory.c +++ b/drivers/infiniband/ulp/iser/iser_memory.c @@ -443,7 +443,7 @@ iser_reg_sig_mr(struct iscsi_iser_task *iser_task, memset(sig_attrs, 0, sizeof(*sig_attrs)); ret = iser_set_sig_attrs(iser_task->sc, sig_attrs); if (ret) - goto err; + return ret; iser_set_prot_checks(iser_task->sc, &sig_attrs->check_mask); @@ -475,8 +475,7 @@ iser_reg_sig_mr(struct iscsi_iser_task *iser_task, iser_dbg("lkey=0x%x rkey=0x%x addr=0x%llx length=%u\n", sig_reg->sge.lkey, sig_reg->rkey, sig_reg->sge.addr, sig_reg->sge.length); -err: - return ret; + return 0; } static int iser_fast_reg_mr(struct iscsi_iser_task *iser_task, -- 2.6.3