Re: [patch] kexec: potetially using uninitialized variable

Xunlei Pang
2016-03-11T08:52:43Z

Hi Dan,

On 2016/03/11 at 16:07, Dan Carpenter wrote:
> At the end of the function we check if "ret" has a negative error code,
> but it seems possible that it is uninitialized.
>
> Fixes: 12db5562e035 ('kexec: load and relocate purgatory at kernel load time')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 503bc2d..63d1af3 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -795,7 +795,7 @@ out:
>
> static int kexec_apply_relocations(struct kimage *image)
> {
> - int i, ret;
> + int i, ret = 0;
> struct purgatory_info *pi = &image->purgatory_info;
> Elf_Shdr *sechdrs = pi->sechdrs;
>

Look further, there is a condition at the beginning of the for loop:

if (sechdrs[i].sh_type != SHT_RELA &&
sechdrs[i].sh_type != SHT_REL)
continue;

So, I think that's ok, but I don't konw if GCC is smart enough not to throw warnings.

Regards,
Xunlei