From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Bird <tim.bird@sonymobile.com>
Date: Thu, 14 Apr 2016 00:35:22 +0000
Subject: Re: [patch] ARM: qcom: silence an uninitialized variable warning
Message-Id: <570EE5CA.5000801@sonymobile.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20160413064511.GG8092@mwanda>
In-Reply-To: <20160413064511.GG8092@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>



On 04/12/2016 11:45 PM, Dan Carpenter wrote:
> It's harmless but, if "enable" isn't set, then we pass uninitialized
> values to qcom_coincell_chgr_config().  The values aren't used, but
> let's silence the warning anyway.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c
> index 7b4a2da..829a61d 100644
> --- a/drivers/misc/qcom-coincell.c
> +++ b/drivers/misc/qcom-coincell.c
> @@ -94,7 +94,8 @@ static int qcom_coincell_probe(struct platform_device *pdev)
>  {
>  	struct device_node *node = pdev->dev.of_node;
>  	struct qcom_coincell chgr;
> -	u32 rset, vset;
> +	u32 rset = 0;
> +	u32 vset = 0;
>  	bool enable;
>  	int rc;
>  
> 
Looks OK to me.  Thanks for the warning cleanup!

Acked-by: Tim Bird
 -- Tim