* [PATCH] afs: do not set task state after schedule_timeout()
@ 2010-07-26 8:27 Kulikov Vasiliy
2010-07-26 11:32 ` David Howells
0 siblings, 1 reply; 2+ messages in thread
From: Kulikov Vasiliy @ 2010-07-26 8:27 UTC (permalink / raw)
To: kernel-janitors; +Cc: David Howells, Tejun Heo, linux-afs, linux-kernel
schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
to set it explicitly.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
---
fs/afs/vlocation.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/afs/vlocation.c b/fs/afs/vlocation.c
index 9ac260d..21f270d 100644
--- a/fs/afs/vlocation.c
+++ b/fs/afs/vlocation.c
@@ -130,7 +130,6 @@ static int afs_vlocation_access_vl_by_id(struct afs_vlocation *vl,
/* second+ BUSY - sleep a little bit */
set_current_state(TASK_UNINTERRUPTIBLE);
schedule_timeout(1);
- __set_current_state(TASK_RUNNING);
}
continue;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] afs: do not set task state after schedule_timeout()
2010-07-26 8:27 [PATCH] afs: do not set task state after schedule_timeout() Kulikov Vasiliy
@ 2010-07-26 11:32 ` David Howells
0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2010-07-26 11:32 UTC (permalink / raw)
To: Kulikov Vasiliy
Cc: dhowells, kernel-janitors, Tejun Heo, linux-afs, linux-kernel
Kulikov Vasiliy <segooon@gmail.com> wrote:
> schedule_timeout() sets tast state to TASK_RUNNING, so there's no need
> to set it explicitly.
>
> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-26 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-26 8:27 [PATCH] afs: do not set task state after schedule_timeout() Kulikov Vasiliy
2010-07-26 11:32 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).