* [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned
@ 2016-04-14 15:40 Slawomir Stepien
2016-04-17 9:31 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Slawomir Stepien @ 2016-04-14 15:40 UTC (permalink / raw)
To: lars, Michael.Hennerich, jic23, knaack.h, pmeerw
Cc: linux-iio, kernel-janitors
This fix checkpatch warnings:
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
Signed-off-by: Slawomir Stepien <sst@poczta.fm>
---
drivers/iio/frequency/ad9523.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 44a30f2..99eba52 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -284,7 +284,7 @@ struct ad9523_state {
} data[2] ____cacheline_aligned;
};
-static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
+static int ad9523_read(struct iio_dev *indio_dev, unsigned int addr)
{
struct ad9523_state *st = iio_priv(indio_dev);
int ret;
@@ -318,7 +318,8 @@ static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
return ret;
};
-static int ad9523_write(struct iio_dev *indio_dev, unsigned addr, unsigned val)
+static int ad9523_write(struct iio_dev *indio_dev,
+ unsigned int addr, unsigned int val)
{
struct ad9523_state *st = iio_priv(indio_dev);
int ret;
@@ -351,11 +352,11 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
}
static int ad9523_vco_out_map(struct iio_dev *indio_dev,
- unsigned ch, unsigned out)
+ unsigned int ch, unsigned int out)
{
struct ad9523_state *st = iio_priv(indio_dev);
int ret;
- unsigned mask;
+ unsigned int mask;
switch (ch) {
case 0 ... 3:
@@ -405,7 +406,7 @@ static int ad9523_vco_out_map(struct iio_dev *indio_dev,
}
static int ad9523_set_clock_provider(struct iio_dev *indio_dev,
- unsigned ch, unsigned long freq)
+ unsigned int ch, unsigned long freq)
{
struct ad9523_state *st = iio_priv(indio_dev);
long tmp1, tmp2;
@@ -619,7 +620,7 @@ static int ad9523_read_raw(struct iio_dev *indio_dev,
long m)
{
struct ad9523_state *st = iio_priv(indio_dev);
- unsigned code;
+ unsigned int code;
int ret;
mutex_lock(&indio_dev->mlock);
@@ -655,7 +656,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev,
long mask)
{
struct ad9523_state *st = iio_priv(indio_dev);
- unsigned reg;
+ unsigned int reg;
int ret, tmp, code;
mutex_lock(&indio_dev->mlock);
@@ -709,8 +710,8 @@ out:
}
static int ad9523_reg_access(struct iio_dev *indio_dev,
- unsigned reg, unsigned writeval,
- unsigned *readval)
+ unsigned int reg, unsigned int writeval,
+ unsigned int *readval)
{
int ret;
--
2.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned
2016-04-14 15:40 [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned Slawomir Stepien
@ 2016-04-17 9:31 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2016-04-17 9:31 UTC (permalink / raw)
To: Slawomir Stepien, lars, Michael.Hennerich, knaack.h, pmeerw
Cc: linux-iio, kernel-janitors
On 14/04/16 16:40, Slawomir Stepien wrote:
> This fix checkpatch warnings:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Slawomir Stepien <sst@poczta.fm>
Applied to the togreg branch of iio.git
Thanks,
Jonathan
> ---
> drivers/iio/frequency/ad9523.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 44a30f2..99eba52 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -284,7 +284,7 @@ struct ad9523_state {
> } data[2] ____cacheline_aligned;
> };
>
> -static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> +static int ad9523_read(struct iio_dev *indio_dev, unsigned int addr)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -318,7 +318,8 @@ static int ad9523_read(struct iio_dev *indio_dev, unsigned addr)
> return ret;
> };
>
> -static int ad9523_write(struct iio_dev *indio_dev, unsigned addr, unsigned val)
> +static int ad9523_write(struct iio_dev *indio_dev,
> + unsigned int addr, unsigned int val)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> @@ -351,11 +352,11 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
> }
>
> static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> - unsigned ch, unsigned out)
> + unsigned int ch, unsigned int out)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> int ret;
> - unsigned mask;
> + unsigned int mask;
>
> switch (ch) {
> case 0 ... 3:
> @@ -405,7 +406,7 @@ static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> }
>
> static int ad9523_set_clock_provider(struct iio_dev *indio_dev,
> - unsigned ch, unsigned long freq)
> + unsigned int ch, unsigned long freq)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> long tmp1, tmp2;
> @@ -619,7 +620,7 @@ static int ad9523_read_raw(struct iio_dev *indio_dev,
> long m)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned code;
> + unsigned int code;
> int ret;
>
> mutex_lock(&indio_dev->mlock);
> @@ -655,7 +656,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev,
> long mask)
> {
> struct ad9523_state *st = iio_priv(indio_dev);
> - unsigned reg;
> + unsigned int reg;
> int ret, tmp, code;
>
> mutex_lock(&indio_dev->mlock);
> @@ -709,8 +710,8 @@ out:
> }
>
> static int ad9523_reg_access(struct iio_dev *indio_dev,
> - unsigned reg, unsigned writeval,
> - unsigned *readval)
> + unsigned int reg, unsigned int writeval,
> + unsigned int *readval)
> {
> int ret;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-17 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-14 15:40 [PATCH] iio: frequency: ad9523: use unsigned int rather then bare unsigned Slawomir Stepien
2016-04-17 9:31 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).