From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Date: Thu, 26 May 2016 10:16:03 +0000 Subject: Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check Message-Id: <5746CCE3.5010701@samsung.com> List-Id: References: <20160526064541.GA6680@mwanda> <5746AFE3.6030606@samsung.com> <20160526100238.GN11011@mwanda> In-Reply-To: <20160526100238.GN11011@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Dan Carpenter Cc: Julia Lawall , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kernel-janitors@vger.kernel.org On 2016년 05월 26일 19:02, Dan Carpenter wrote: > On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote: >> I don't recommend that you mention the name of engineer on patch description >> directly. Except for this comment, looks good to me. > > I always feel it's nicer to give credit. Plus Julia is already a well > known kernel dev and this was a pubic list. (I wouldn't give credit if > she had sent hurtful comments about my spelling to me privately, for > example). If you want to give credit as you mentioned, you can add the acked-by or signed-off for Julia. But, usually, the patch description don't include the engineer's name directly. Thanks, Chanwoo Choi