From: Jason Wang <jasowang@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [bug report] macvtap: switch to use skb array
Date: Tue, 19 Jul 2016 06:33:19 +0000 [thread overview]
Message-ID: <578DC9AF.4020708@redhat.com> (raw)
In-Reply-To: <20160718150651.GA31660@mwanda>
On 2016年07月19日 02:26, Dan Carpenter wrote:
> Hello Jason Wang,
>
> The patch 362899b8725b: "macvtap: switch to use skb array" from Jul
> 15, 2016, leads to the following static checker warning:
>
> drivers/net/macvtap.c:539 macvtap_sock_destruct()
> error: use kfree_skb() here instead of kfree(skb)
>
> drivers/net/macvtap.c
> 533 static void macvtap_sock_destruct(struct sock *sk)
> 534 {
> 535 struct macvtap_queue *q = container_of(sk, struct macvtap_queue, sk);
> 536 struct sk_buff *skb;
> 537
> 538 while ((skb = skb_array_consume(&q->skb_array)) != NULL)
> 539 kfree(skb);
>
> Should be kfree_skb(). On my way to airport or would send patch.
Patch sent, thanks a lot!
>
> 540 }
>
> regards,
> dan carpenter
prev parent reply other threads:[~2016-07-19 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 18:26 [bug report] macvtap: switch to use skb array Dan Carpenter
2016-07-19 6:33 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578DC9AF.4020708@redhat.com \
--to=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox