From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Sat, 03 Sep 2016 12:42:57 +0000 Subject: Re: [PATCH 09/17] s390/debug: Return directly if a null pointer was passed to debug_unregister() Message-Id: <57CAC551.7040505@bfs.de> List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <9c7f85c9-75db-99fb-88ce-b3e6f01b69db@users.sourceforge.net> In-Reply-To: <9c7f85c9-75db-99fb-88ce-b3e6f01b69db@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini Am 03.09.2016 14:24, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Thu, 1 Sep 2016 19:34:45 +0200 > > Return directly at the beginning if a null pointer was passed for > the input parameter of this function. > > Signed-off-by: Markus Elfring > --- > arch/s390/kernel/debug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c > index c4a4641..d137150 100644 > --- a/arch/s390/kernel/debug.c > +++ b/arch/s390/kernel/debug.c > @@ -736,13 +736,10 @@ void > debug_unregister(debug_info_t * id) > { > if (!id) > - goto out; > + return; > mutex_lock(&debug_mutex); > debug_info_put(id); > mutex_unlock(&debug_mutex); > - > -out: > - return; > } > EXPORT_SYMBOL(debug_unregister); > debug_info_put() will check for NULL, the whole check can be removed. re, wh