From: SF Markus Elfring <elfring@users.sourceforge.net>
To: devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create()
Date: Thu, 11 May 2017 16:17:01 +0000 [thread overview]
Message-ID: <587dbcf5-8b12-fac7-693e-5f471e6d5167@users.sourceforge.net> (raw)
In-Reply-To: <dea9c6a3-0ae6-f3fe-c0d3-7f5b856e2638@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 11 May 2017 17:33:14 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hv/vmbus_drv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 6802d74f162c..96328aebae5a 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -1149,7 +1149,5 @@ struct hv_device *vmbus_device_create(const uuid_le *type,
- if (!child_device_obj) {
- pr_err("Unable to allocate device object for child device\n");
+ if (!child_device_obj)
return NULL;
- }
child_device_obj->channel = channel;
memcpy(&child_device_obj->dev_type, type, sizeof(uuid_le));
--
2.12.3
next prev parent reply other threads:[~2017-05-11 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 16:14 [PATCH 0/4] VMBus: Adjustments for some function implementations SF Markus Elfring
2017-05-11 16:15 ` [PATCH 1/4] vmbus: Improve a size determination in vmbus_device_create() SF Markus Elfring
2017-05-11 16:30 ` Stephen Hemminger
2017-05-11 17:47 ` Greg KH
2017-05-11 16:17 ` SF Markus Elfring [this message]
2017-05-11 16:30 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Stephen Hemminger
2017-05-11 16:36 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() SF Markus Elfring
2017-05-11 16:42 ` Stephen Hemminger
2017-05-12 7:09 ` [PATCH 2/4] vmbus: Delete an error message for a failed memory allocation in vmbus_device_create Dan Carpenter
2017-05-12 7:32 ` vmbus: Delete an error message for a failed memory allocation in vmbus_device_create() SF Markus Elfring
2017-05-12 7:52 ` Joe Perches
2017-05-12 8:23 ` Clarification for general change acceptance SF Markus Elfring
2017-05-12 8:37 ` Julia Lawall
2017-05-12 8:45 ` SF Markus Elfring
2017-05-11 16:18 ` [PATCH 3/4] vmbus: Fix a typo in a comment line SF Markus Elfring
2017-05-11 16:33 ` Stephen Hemminger
2017-05-11 16:19 ` [PATCH 4/4] vmbus: Adjust five checks for null pointers SF Markus Elfring
2017-05-11 16:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=587dbcf5-8b12-fac7-693e-5f471e6d5167@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox