From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] net: qcom/emac: fix a sizeof() typo
Date: Mon, 13 Feb 2017 15:57:57 +0000 [thread overview]
Message-ID: <58A1D785.5040105@bfs.de> (raw)
In-Reply-To: <20170213110021.GA17205@mwanda>
Am 13.02.2017 16:43, schrieb Timur Tabi:
> walter harms wrote:
>> The question is: why is a simple calculation const*const
>> separated into a function ?
>
> This is a callback function. That's just how it's defined.
>
> It's rare, but there are drivers that use the parameter, like this one:
>
> http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c#n591
>
>
this is the problem:
I used: http://lxr.free-electrons.com/source/drivers/net/ibm_emac/ibm_emac_core.c?v=2.6.24#L1778
here is the patched function emac_get_regs_len used the calculate the length in emac_ethtool_get_regs_len
what is used as callback.
in
http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/tree/drivers/net/ethernet/qualcomm/emac/emac-ethtool.c
is it now used directly.
sorry for the noise,
re,
wh
next prev parent reply other threads:[~2017-02-13 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 11:00 [patch net-next] net: qcom/emac: fix a sizeof() typo Dan Carpenter
2017-02-13 11:55 ` walter harms
2017-02-13 13:03 ` Timur Tabi
2017-02-13 13:28 ` walter harms
2017-02-13 15:43 ` Timur Tabi
2017-02-13 14:00 ` Dan Carpenter
2017-02-13 15:43 ` Timur Tabi
2017-02-13 15:57 ` walter harms [this message]
2017-02-13 16:23 ` Timur Tabi
2017-02-14 3:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58A1D785.5040105@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox