* [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c
@ 2017-02-19 5:50 Saurabh Badhwar
2017-02-19 13:19 ` walter harms
0 siblings, 1 reply; 2+ messages in thread
From: Saurabh Badhwar @ 2017-02-19 5:50 UTC (permalink / raw)
To: linux-kernel; +Cc: kernel-janitors
Fix possible resource leak in tools/vm/page_owner_sort.c
Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
---
tools/vm/page_owner_sort.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
index f1c055f..8346261 100644
--- a/tools/vm/page_owner_sort.c
+++ b/tools/vm/page_owner_sort.c
@@ -110,6 +110,8 @@ int main(int argc, char **argv)
buf = malloc(BUF_SIZE);
if (!list || !buf) {
printf("Out of memory\n");
+ fclose(fin);
+ fclose(fout);
exit(1);
}
@@ -144,6 +146,7 @@ int main(int argc, char **argv)
for (i = 0; i < count; i++)
fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
-
+
+ fclose(fout);
return 0;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c
2017-02-19 5:50 [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c Saurabh Badhwar
@ 2017-02-19 13:19 ` walter harms
0 siblings, 0 replies; 2+ messages in thread
From: walter harms @ 2017-02-19 13:19 UTC (permalink / raw)
To: Saurabh Badhwar; +Cc: linux-kernel, kernel-janitors
Am 19.02.2017 06:49, schrieb Saurabh Badhwar:
> Fix possible resource leak in tools/vm/page_owner_sort.c
> Signed-off-by: Saurabh Badhwar <sbsaurabhbadhwar9@gmail.com>
> ---
> tools/vm/page_owner_sort.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c
> index f1c055f..8346261 100644
> --- a/tools/vm/page_owner_sort.c
> +++ b/tools/vm/page_owner_sort.c
> @@ -110,6 +110,8 @@ int main(int argc, char **argv)
> buf = malloc(BUF_SIZE);
> if (!list || !buf) {
> printf("Out of memory\n");
> + fclose(fin);
> + fclose(fout);
> exit(1);
> }
the is no resource leak as file pointer get closed on exit
ntl it is ok the close them
but error messages should go to stderr an be more verbose.
just my 2 cents,
wh
>
> @@ -144,6 +146,7 @@ int main(int argc, char **argv)
>
> for (i = 0; i < count; i++)
> fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt);
> -
> +
> + fclose(fout);
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-19 13:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-19 5:50 [PATCH] tools/vm: Fix possible resource leak in page_owner_sort.c Saurabh Badhwar
2017-02-19 13:19 ` walter harms
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox